pitrou commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1274962828
##########
cpp/src/arrow/type_traits.h:
##########
@@ -1187,7 +1202,6 @@ constexpr bool is_var_length_list(Type::type type_id) {
switch (type_id) {
case Type::LIST:
case Type::LARGE_LIST:
- case Type::MAP:
Review Comment:
Well, 1) It is a public API, so we probably shouldn't change the current
semantics, 2) one should review internal uses of it to make sure changing it
doesn't break anything that wouldn't be adequately tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
