danepitkin commented on code in PR #36842:
URL: https://github.com/apache/arrow/pull/36842#discussion_r1275263223
##########
python/pyarrow/_dataset.pyx:
##########
@@ -3337,7 +3337,7 @@ cdef class Scanner(_Weakrefable):
----------
dataset : Dataset
Dataset to scan.
- columns : list of str, default None
+ columns : list of str or dict, default None
Review Comment:
We could use `dict or list of str`. It doesn't seem like there is precedence
in the Arrow docs to use `list[str] or dict`, which could also be nice.
Edit: actually some documentation does use `[]` : e.g.
https://arrow.apache.org/docs/python/generated/pyarrow.Array.html#pyarrow.Array.from_buffers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
