westonpace commented on code in PR #36705: URL: https://github.com/apache/arrow/pull/36705#discussion_r1275390233
########## dev/tasks/homebrew-formulae/apache-arrow.rb: ########## @@ -57,7 +57,8 @@ class ApacheArrow < Formula fails_with gcc: "5" def install - # https://github.com/Homebrew/homebrew-core/issues/76537 + # This isn't for https://github.com/Homebrew/homebrew-core/issues/76537 . Review Comment: Is deleting the old comment enough? Is there a reason a future reader would think this is related to 76537? ########## dev/tasks/r/github.macos.brew.yml: ########## @@ -24,21 +24,33 @@ jobs: name: "Homebrew + R package" runs-on: macOS-11 steps: + - name: Show system information + run: | + sysctl hw.optional machdep.cpu + {{ macros.github_checkout_arrow()|indent }} {{ macros.configure_homebrew_arrow(formula)|indent }} - name: Install apache-arrow env: - {{ macros.github_set_sccache_envvars()|indent(8)}} + {{ macros.github_set_sccache_envvars()|indent(8)}} run: | - brew install sccache # for testing brew install minio - + # TODO(ARROW-16907): apache/arrow@main seems to be installed already # so this does nothing on a branch/PR - brew install -v --HEAD apache-arrow + brew install -v --HEAD {{ '$(brew --repository homebrew/core)/Formula/apache-arrow.rb' }} Review Comment: Why is this needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
