kou commented on code in PR #36705:
URL: https://github.com/apache/arrow/pull/36705#discussion_r1275640005
##########
dev/tasks/r/github.macos.brew.yml:
##########
@@ -24,21 +24,33 @@ jobs:
name: "Homebrew + R package"
runs-on: macOS-11
steps:
+ - name: Show system information
+ run: |
+ sysctl hw.optional machdep.cpu
+
{{ macros.github_checkout_arrow()|indent }}
{{ macros.configure_homebrew_arrow(formula)|indent }}
- name: Install apache-arrow
env:
- {{ macros.github_set_sccache_envvars()|indent(8)}}
+ {{ macros.github_set_sccache_envvars()|indent(8)}}
run: |
-
brew install sccache
# for testing
brew install minio
-
+
# TODO(ARROW-16907): apache/arrow@main seems to be installed already
# so this does nothing on a branch/PR
- brew install -v --HEAD apache-arrow
+ brew install -v --HEAD {{ '$(brew --repository
homebrew/core)/Formula/apache-arrow.rb' }}
Review Comment:
We need to specify absolute path for a formula to use the local modified
version. (We didn't need this with old Homebrew.)
I think that it's related to the "Using JSON files downloaded from
[formulae.brew.sh](https://formulae.brew.sh/) for package installation rather
than local homebrew/core and homebrew/cask taps." change in Homebrew 4.0.0:
https://brew.sh/2023/02/16/homebrew-4.0.0/
We may be able to use `HOMEBREW_NO_INSTALL_FROM_API=1` instead of specifying
an absolute path. But I think that the absolute path approach is
straightforward.
##########
dev/tasks/homebrew-formulae/apache-arrow.rb:
##########
@@ -57,7 +57,8 @@ class ApacheArrow < Formula
fails_with gcc: "5"
def install
- # https://github.com/Homebrew/homebrew-core/issues/76537
+ # This isn't for https://github.com/Homebrew/homebrew-core/issues/76537 .
Review Comment:
Can we defer this to another PR?
To be honest, I want to remove `ENV.runtime_cpu_detection if
Hardware::CPU.intel?` entirely or remove `if Hardware::CPU.intel?`. If I do the
change, we can remove this.
But I want to keep this in this PR to clarify we choose "1.
`-DARROW_RUNTIME_SIMD_LEVEL=NONE` instead of "2. Remove
`ENV.runtime_cpu_detection if Hardware::CPU.intel?`".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
