mustafasrepo commented on code in PR #7129: URL: https://github.com/apache/arrow-datafusion/pull/7129#discussion_r1277718979
########## datafusion/core/tests/sqllogictests/test_files/groupby.slt: ########## @@ -1960,21 +1960,20 @@ SortPreservingMergeExec: [col0@0 ASC NULLS LAST] --SortExec: expr=[col0@0 ASC NULLS LAST] ----ProjectionExec: expr=[col0@0 as col0, LAST_VALUE(r.col1) ORDER BY [r.col0 ASC NULLS LAST]@3 as last_col1] ------AggregateExec: mode=FinalPartitioned, gby=[col0@0 as col0, col1@1 as col1, col2@2 as col2], aggr=[LAST_VALUE(r.col1)] ---------SortExec: expr=[col0@3 ASC NULLS LAST] Review Comment: Generally in the plan `SortExec` before `AggregateExec: mode=FinalPartitioned` or `AggregateExec: mode=Final` is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
