mustafasrepo commented on code in PR #7129: URL: https://github.com/apache/arrow-datafusion/pull/7129#discussion_r1277720658
########## datafusion/core/tests/sqllogictests/test_files/groupby.slt: ########## @@ -2760,8 +2772,8 @@ Projection: FIRST_VALUE(sales_global.amount) ORDER BY [sales_global.ts ASC NULLS physical_plan ProjectionExec: expr=[FIRST_VALUE(sales_global.amount) ORDER BY [sales_global.ts ASC NULLS LAST]@0 as fv1, LAST_VALUE(sales_global.amount) ORDER BY [sales_global.ts ASC NULLS LAST]@1 as fv2] --AggregateExec: mode=Final, gby=[], aggr=[FIRST_VALUE(sales_global.amount), LAST_VALUE(sales_global.amount)] -----SortPreservingMergeExec: [ts@0 ASC NULLS LAST] Review Comment: Also `SortPreservingMergeExec` is replaced with `CoalescePartitionsExec`. since in final mode we no longer require any ordering for its input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
