viirya commented on code in PR #7126:
URL: https://github.com/apache/arrow-datafusion/pull/7126#discussion_r1278065861
##########
datafusion/core/src/physical_plan/filter.rs:
##########
@@ -191,11 +190,8 @@ impl ExecutionPlan for FilterExec {
fn statistics(&self) -> Statistics {
let predicate = self.predicate();
- if let Some(binary) = predicate.as_any().downcast_ref::<BinaryExpr>() {
- let columns = collect_columns(predicate);
- if !is_operator_supported(binary.op()) || columns.is_empty() {
- return Statistics::default();
- }
+ if !check_support(predicate) {
Review Comment:
I guess it means if the predicate doesn't involve any column, we cannot do
selectivity check so just return default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
