berkaysynnada commented on PR #7126:
URL: 
https://github.com/apache/arrow-datafusion/pull/7126#issuecomment-1656592421

   > @berkaysynnada do you perhaps have time to review this PR?
   
   LGTM, thank you for the fix. Actually, it's good that you've removed the 
default return in the case that there is no column in the predicate. We don't 
need to provide a default return for those with 0 selective deterministic 
filters. Now, the calculations will yield a 0 selectivity result for these 
cases, instead of returning a default (as in the instance of 1>2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to