emkornfield commented on code in PR #36574:
URL: https://github.com/apache/arrow/pull/36574#discussion_r1278318416
##########
cpp/src/parquet/page_index.h:
##########
@@ -38,10 +41,10 @@ class RowGroupPageIndexReader;
class PARQUET_EXPORT ColumnIndex {
public:
/// \brief Create a ColumnIndex from a serialized thrift message.
- static std::unique_ptr<ColumnIndex> Make(const ColumnDescriptor& descr,
- const void* serialized_index,
- uint32_t index_len,
- const ReaderProperties& properties);
+ static std::unique_ptr<ColumnIndex> Make(
+ const ColumnDescriptor& descr, const void* serialized_index, uint32_t
index_len,
+ const ReaderProperties& properties,
+ const std::shared_ptr<Decryptor>& decryptor = NULLPTR);
Review Comment:
I think if we are sharing ownership the shared_ptr should be passed by
value. If we do not intend to share ownership pass by raw pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
