emkornfield commented on code in PR #36574:
URL: https://github.com/apache/arrow/pull/36574#discussion_r1278318429
##########
cpp/src/parquet/page_index.h:
##########
@@ -124,9 +127,10 @@ struct PARQUET_EXPORT PageLocation {
class PARQUET_EXPORT OffsetIndex {
public:
/// \brief Create a OffsetIndex from a serialized thrift message.
- static std::unique_ptr<OffsetIndex> Make(const void* serialized_index,
- uint32_t index_len,
- const ReaderProperties& properties);
+ static std::unique_ptr<OffsetIndex> Make(
+ const void* serialized_index, uint32_t index_len,
+ const ReaderProperties& properties,
+ const std::shared_ptr<Decryptor>& decryptor = NULLPTR);
Review Comment:
same comments as above on signature.
##########
cpp/src/parquet/page_index.h:
##########
@@ -283,7 +287,9 @@ class PARQUET_EXPORT ColumnIndexBuilder {
/// not write any data to the sink.
///
/// \param[out] sink output stream to write the serialized message.
- virtual void WriteTo(::arrow::io::OutputStream* sink) const = 0;
+ /// \param[in] encryptor encryptor to encrypt the serialized column index.
+ virtual void WriteTo(::arrow::io::OutputStream* sink,
Review Comment:
same comments as above on signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
