Dandandan commented on code in PR #7155:
URL: https://github.com/apache/arrow-datafusion/pull/7155#discussion_r1280392875
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -757,7 +757,7 @@ pub fn build_equal_condition_join_indices(
let mut build_indices = UInt64BufferBuilder::new(0);
let mut probe_indices = UInt32BufferBuilder::new(0);
// Visit all of the probe rows
- for (row, hash_value) in hash_values.iter().enumerate() {
+ for (row, hash_value) in hash_values.iter().enumerate().rev() {
Review Comment:
So there seems there was no test for checking the ordering of the hash join
results (only for the matching rows to be correct) @metesynnada changed one to
test this. This is important if the execution plan depends on the output
ordering (and doesn't add extra sort).
The matching rows themselves are correct even before this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
