liukun4515 commented on PR #7155: URL: https://github.com/apache/arrow-datafusion/pull/7155#issuecomment-1661865079
> Thanks @metesynnada and @ozankabak for the extra review. > > I felt certain that this is the correct change so went ahead with the merge. @liukun4515 let us know if you have any worries. In this issue https://github.com/apache/arrow-datafusion/issues/7113 @metesynnada describe the issue ``` In the current implementation of calculate_hash_join_output_order, we operate under the assumption that the order of the build side is also preserved lexicographically. ``` But I review the code of `calculate_join_output_ordering`, and find the build side are not preserved the order Does we need to preserve the order for the build side? From the implementation of `calculate_join_output_ordering`, I think we should just maintain the order of the probe side. Does I miss something？ @Dandandan @ozankabak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
