seddonm1 opened a new pull request #9038:
URL: https://github.com/apache/arrow/pull/9038
This PR is a work-in-progress simple implementation of `InList` (`'ABC' IN
('ABC', 'DEF')`) which currently only operates on strings.
It uses the `kernels::comparison::contains` implementation but there are a
few issues I am struggling with:
1. `kernels::comparison::contains` allows each value in the input array to
match against potentially different value arrays. My implementation is very
inefficiently creating the same array n times to prevent the error of
mismatched input lengths
(https://github.com/apache/arrow/blob/master/rust/arrow/src/compute/kernels/comparison.rs#L696).
Is there a more efficient way to create these `ListArray`s?
2. `kernels::comparison::contains` returns `false` if either of the
comparison values is `null`. Is this the desired behavior? If not I can modify
the kernel to return null instead.
3. If the basic implementation looks correct I can add the rest of the data
types (via macros).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
