seddonm1 commented on a change in pull request #9038:
URL: https://github.com/apache/arrow/pull/9038#discussion_r549888900
##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -158,6 +158,15 @@ pub enum Expr {
/// List of expressions to feed to the functions as arguments
args: Vec<Expr>,
},
+ /// Returns whether the list contains the expr value.
+ InList {
+ /// The value to compare
+ expr: Box<Expr>,
+ /// The low end of the range
+ list: Vec<Expr>,
Review comment:
I cannot find another example where we do validation like checking same
datatypes in the Logical Plan. Most of this type of validation is performed in
the Physical Plan:
https://github.com/apache/arrow/blob/master/rust/datafusion/src/physical_plan/expressions.rs#L1650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
