ywc88 commented on code in PR #955:
URL: https://github.com/apache/arrow-adbc/pull/955#discussion_r1281165388
##########
c/driver/sqlite/sqlite_test.cc:
##########
@@ -190,10 +190,10 @@ class SqliteStatementTest : public ::testing::Test,
void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpTest()); }
void TearDown() override { ASSERT_NO_FATAL_FAILURE(TearDownTest()); }
- void TestSqlIngestUInt64() {
- std::vector<std::optional<uint64_t>> values = {std::nullopt, 0, INT64_MAX};
- return TestSqlIngestType(NANOARROW_TYPE_UINT64, values);
- }
+ void TestSqlIngestUInt8() { GTEST_SKIP() << "Not implemented"; }
+ void TestSqlIngestUInt16() { GTEST_SKIP() << "Not implemented"; }
+ void TestSqlIngestUInt32() { GTEST_SKIP() << "Not implemented"; }
+ void TestSqlIngestUInt64() { GTEST_SKIP() << "Not implemented"; }
Review Comment:
My understanding is that an int overflow can happen (and I assumed that's
why it's also skipped in PostgreSQL) since BIGINT in PostgreSQL and INTEGER in
SQLite support up to 2^63 - 1 but `uint64_t` can go up to 2^64 - 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
