ywc88 commented on code in PR #955:
URL: https://github.com/apache/arrow-adbc/pull/955#discussion_r1282368879
##########
c/driver/sqlite/sqlite.c:
##########
@@ -1025,6 +1027,46 @@ AdbcStatusCode SqliteStatementInitIngest(struct
SqliteStatement* stmt,
goto cleanup;
}
+ int status =
+ ArrowSchemaViewInit(&view, stmt->binder.schema.children[i],
&arrow_error);
+ if (status != 0) {
+ SetError(error, "Failed to parse schema for column %d: %s (%d): %s", i,
+ strerror(status), status, arrow_error.message);
+ code = ADBC_STATUS_INTERNAL;
+ goto cleanup;
+ }
Review Comment:
I tried moving `ArrowSchemaViewInit(&view, stmt->binder.schema.children[i],
&arrow_error); ` out of the loop and rewriting it to
`ArrowSchemaViewInit(&view, stmt->binder.schema.dictionary, &arrow_error); `but
got a bunch of tests failing:
```
[ FAILED ] 26 tests, listed below:
[ FAILED ] SqliteConnectionTest.MetadataGetTableSchema
[ FAILED ] SqliteConnectionTest.MetadataGetObjectsTables
[ FAILED ] SqliteConnectionTest.MetadataGetObjectsTablesTypes
[ FAILED ] SqliteConnectionTest.MetadataGetObjectsColumns
[ FAILED ] SqliteStatementTest.SqlIngestInt8
[ FAILED ] SqliteStatementTest.SqlIngestInt16
[ FAILED ] SqliteStatementTest.SqlIngestInt32
[ FAILED ] SqliteStatementTest.SqlIngestInt64
[ FAILED ] SqliteStatementTest.SqlIngestUInt8
[ FAILED ] SqliteStatementTest.SqlIngestUInt16
[ FAILED ] SqliteStatementTest.SqlIngestUInt32
[ FAILED ] SqliteStatementTest.SqlIngestUInt64
[ FAILED ] SqliteStatementTest.SqlIngestFloat32
[ FAILED ] SqliteStatementTest.SqlIngestFloat64
[ FAILED ] SqliteStatementTest.SqlIngestString
[ FAILED ] SqliteStatementTest.SqlIngestDate32
[ FAILED ] SqliteStatementTest.SqlIngestTimestamp
[ FAILED ] SqliteStatementTest.SqlIngestTimestampTz
[ FAILED ] SqliteStatementTest.SqlIngestTableEscaping
[ FAILED ] SqliteStatementTest.SqlIngestAppend
[ FAILED ] SqliteStatementTest.SqlIngestErrors
[ FAILED ] SqliteStatementTest.SqlIngestMultipleConnections
[ FAILED ] SqliteStatementTest.SqlIngestSample
[ FAILED ] SqliteStatementTest.SqlPrepareUpdate
[ FAILED ] SqliteStatementTest.SqlPrepareUpdateStream
[ FAILED ] SqliteStatementTest.Transactions
```
Example:
```
/Users/ywc/VoDa/arrow-adbc/c/validation/adbc_validation.cc:91: Failure
Value of: DoIngestSampleTable(connection, "bulk_ingest", error)
Expected: is 0 (OK)
Actual: '\t' (9) (of type unsigned char), 9 (INTERNAL)
/Users/ywc/VoDa/arrow-adbc/c/validation/adbc_validation.cc:2172: Failure
Expected: IngestSampleTable(&connection, &error) doesn't generate new fatal
failures in the current thread.
Actual: it does.
[ FAILED ] SqliteStatementTest.Transactions (0 ms)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
