quinnj commented on code in PR #477: URL: https://github.com/apache/arrow-julia/pull/477#discussion_r1284712926
########## src/arraytypes/arraytypes.jl: ########## @@ -200,6 +200,7 @@ end Base.size(p::ValidityBitmap) = (p.ℓ,) nullcount(x::ValidityBitmap) = x.nc +Base.all(x::ValidityBitmap) = x.nc == 0 Review Comment: I don't love overloading `all` here; can we just call this `allvalid`? I don't think we need to overload anything for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
