quinnj commented on code in PR #477:
URL: https://github.com/apache/arrow-julia/pull/477#discussion_r1284713427
##########
src/eltypes.jl:
##########
@@ -540,13 +555,13 @@ function UnionT(f::Meta.Field, convert)
UT = UnionT{
f.type.mode,
typeids,
- Tuple{(juliaeltype(x, buildmetadata(x), convert) for x in
f.children)...},
+ Tuple{(juliaeltype(x, buildmetadata(x), convert, false) for x in
f.children)...},
Review Comment:
Can you help me understand why we hard-code `false` in a number of places
for the `allvalid` argument? vs. in other places calling `all(validity)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
