rok commented on code in PR #14341:
URL: https://github.com/apache/arrow/pull/14341#discussion_r1285951190
##########
cpp/src/parquet/encoding_test.cc:
##########
@@ -874,7 +874,7 @@ std::shared_ptr<::arrow::Array>
EncodingAdHocTyped<FLBAType>::GetValues(int seed
}
using EncodingAdHocTypedCases =
- ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType,
FLBAType>;
+ ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType>;
Review Comment:
Yes, the change to `EncodingTraits<FLBAType>` breaks `EncodingAdHocTyped`
test. This is to make it's interface equal to the
`EncodingTraits<ByteArrayType>` one to enable templating. Specifically we go
from:
```cpp
struct EncodingTraits<FLBAType> {
using Accumulator = ::arrow::FixedSizeBinaryBuilder;
[...]
```
to:
```cpp
struct EncodingTraits<FLBAType> {
struct Accumulator {
std::unique_ptr<::arrow::FixedSizeBinaryBuilder> builder;
std::vector<std::shared_ptr<::arrow::Array>> chunks;
[...]
```
If we consider `EncodingTraits` external API we should probably avoid this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
