benibus commented on code in PR #36073:
URL: https://github.com/apache/arrow/pull/36073#discussion_r1286326570
##########
cpp/src/parquet/statistics.cc:
##########
@@ -527,9 +616,28 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
void IncrementNumValues(int64_t n) override { num_values_ += n; }
+ static bool IsMeaningfulLogicalType(LogicalType::Type::type type) {
Review Comment:
This just happens to be first logical type that dramatically affects how the
physical value (a `FLBA` in this case) should be interpreted for comparisons.
But I tried to generalize things in case any similar logical types are added in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
