wjones127 opened a new pull request, #4660:
URL: https://github.com/apache/arrow-rs/pull/4660
# Which issue does this PR close?
Closes #4659.
# Rationale for this change
The current implementation doesn't obey the ownership semantics laid out in
the spec. When exporting to other Arrow implementations, it will leak memory
through the `get_last_error()` method. When importing from other Arrow
implementations, it will cause a double free. Also, null pointers aren't being
handled.
# What changes are included in this PR?
Changes `get_last_error` implementations to treat the returned value as a
borrowed and not owned string.
# Are there any user-facing changes?
I don't think so. It's possible that someone using the C Stream Interface to
move data between an older version of arrow-rs and one after this change may
face some FFI issues, but I doubt anyone is doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
