viirya commented on code in PR #4660:
URL: https://github.com/apache/arrow-rs/pull/4660#discussion_r1286375232
##########
arrow/src/ffi_stream.rs:
##########
@@ -142,8 +143,12 @@ unsafe extern "C" fn get_next(
// The callback used to get the error from last operation on the
`FFI_ArrowArrayStream`
unsafe extern "C" fn get_last_error(stream: *mut FFI_ArrowArrayStream) ->
*const c_char {
let mut ffi_stream = ExportedArrayStream { stream };
- let last_error = ffi_stream.get_last_error();
- CString::new(last_error.as_str()).unwrap().into_raw()
+ // The consumer should not take ownership of this string, we should return
+ // a const pointer to it.
+ match ffi_stream.get_last_error() {
+ Some(err_string) => err_string.as_ptr(),
+ None => std::ptr::null(),
+ }
Review Comment:
👍 nice catch
##########
arrow/src/ffi_stream.rs:
##########
@@ -142,8 +143,12 @@ unsafe extern "C" fn get_next(
// The callback used to get the error from last operation on the
`FFI_ArrowArrayStream`
unsafe extern "C" fn get_last_error(stream: *mut FFI_ArrowArrayStream) ->
*const c_char {
let mut ffi_stream = ExportedArrayStream { stream };
- let last_error = ffi_stream.get_last_error();
- CString::new(last_error.as_str()).unwrap().into_raw()
+ // The consumer should not take ownership of this string, we should return
+ // a const pointer to it.
+ match ffi_stream.get_last_error() {
+ Some(err_string) => err_string.as_ptr(),
+ None => std::ptr::null(),
+ }
Review Comment:
👍 nice catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
