sgilmore10 opened a new pull request, #37047:
URL: https://github.com/apache/arrow/pull/37047
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Now that #37043 is merged, we can re-implement `featherwrite` in terms of
the new `arrow.internal.io.feather.Writer` class. Once this change is made, we
can delete the legacy build infrastructure and feather_write mex code.
### What changes are included in this PR?
1. Re-implemented `featherwrite` using `arrow.internal.io.feather.Writer`.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
1. Yes, the existing tests in `tfeather.m` cover these changes.
2. I had to update some of the expected error message IDs in `tfeather.m`
because the new implementation throws errors with different IDs.
3. `featherwrite` used to export the real part of MATLAB complex numeric
arrays. The new version of `featherwrite` now errors if the input table
contains complex data because feather/Arrow itself does not have complex
numeric type. We think this is the right decision choice - just writing out the
real part is lossy.
### Are there any user-facing changes?
Yes, `featherwrite` no longer supports writing complex numeric arrays.
### Future Directions
1. Once this PR is merged, we will remove the legacy build infrastructure
and MEX code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
