tustvold commented on code in PR #4691:
URL: https://github.com/apache/arrow-rs/pull/4691#discussion_r1292317464
##########
arrow-array/src/array/null_array.rs:
##########
@@ -107,22 +109,12 @@ impl Array for NullArray {
None
}
- /// Returns whether the element at `index` is null.
- /// All elements of a `NullArray` are always null.
- fn is_null(&self, _index: usize) -> bool {
Review Comment:
This is a breaking change, although I expect the impact to minimal. I
debated making is_null and friends always return logical nullability, but this
would have been inconsistent with ArrayData and generally seemed like it might
just cause more confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
