tustvold commented on code in PR #4691:
URL: https://github.com/apache/arrow-rs/pull/4691#discussion_r1292321612
##########
arrow-array/src/array/mod.rs:
##########
@@ -277,6 +317,10 @@ impl Array for ArrayRef {
self.as_ref().nulls()
}
+ fn logical_nulls(&self) -> Option<NullBuffer> {
Review Comment:
I considered having this eagerly constructed and stored on the arrays, but I
felt this would be more surprising as it would make the arrays diverge from the
arrow specification. Whilst this does raise the prospect of computing this
NullBuffer multiple times, the cases where this is required are fairly rare. We
can always optimise in future should this become a problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
