jayzhan211 commented on PR #7242: URL: https://github.com/apache/arrow-datafusion/pull/7242#issuecomment-1676246329
Another big issue, we might need Array for aggregate function Sum so we can process array and return ArrayRef. I try to process and return ScalarValue, but ScalarValue::List is not a good replacement for ArrayRef. We might need ColumnarValue that can accept either ScalarValue or ArrayRef for `fn sum_batch` and `SumAccumulator`. https://github.com/apache/arrow-datafusion/blob/00627785718d9d98998021bf44585f32c33af3ea/datafusion/physical-expr/src/aggregate/sum.rs#L269-L300 Unfortunately, we might need to change the signature in `Accumulator` from `ScalarValue` to `ColumnarValue`. Do you think this signature change is a good decision for accepting the Aggregate function to process Array? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
