jayzhan211 commented on code in PR #7242:
URL: https://github.com/apache/arrow-datafusion/pull/7242#discussion_r1292885559
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -1128,10 +1137,37 @@ fn finalize_aggregation(
| AggregateMode::Single
| AggregateMode::SinglePartitioned => {
// merge the state to the final value
- accumulators
+ let res = accumulators
.iter()
- .map(|accumulator| accumulator.evaluate().map(|v|
v.to_array()))
- .collect::<Result<Vec<ArrayRef>>>()
+ .map(|accumulator|
+ {
+ println!("mode: {:?}", mode);
+ let res = accumulator.evaluate_v2();
Review Comment:
The problem is that I need to find a way to represent Array (Column support)
with ScalarValue. So that I can get the ArrayRef from ScalarValue `to_array`.
ScalarValue::List does not fit at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
