sgilmore10 opened a new pull request, #37156:
URL: https://github.com/apache/arrow/pull/37156

   
   
   ### Rationale for this change
   
   Now that the PR introducing the `arrow.internal.validate.inex.numeric()` 
function has been merged (#37150), we should use this utility function within 
the `column()` method of `arrow.tabular.RecordBatch`. Doing so will remove 
duplicate code from the code base.
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   ### What changes are included in this PR?
   
   1. Updated the `column()` method of `arrow.tabular.RecordBatch` to use 
`arrow.internal.validate.index.numeric()`. 
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ### Are these changes tested?
   
   Yes, these changes are covered by these two existing test classes:
   
   1. `test/arrow/tabular/tRecordBatch.m`
   2. `test/arrow/internal/validate/index/tNumeric.m`
   
   ### Are there any user-facing changes?
   
   No.
   
   ### Future Directions
   
   1. In a pull request, we will add support for indexing columns by name. 
Currently, the `column()` method only supports numeric indexing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to