kevingurney commented on code in PR #37156:
URL: https://github.com/apache/arrow/pull/37156#discussion_r1293830983
##########
matlab/test/arrow/tabular/tRecordBatch.m:
##########
@@ -119,7 +119,21 @@ function UnsupportedColumnIndexType(tc)
TOriginal = table(1, 2, 3);
arrowRecordBatch = arrow.recordbatch(TOriginal);
fcn = @() arrowRecordBatch.column(datetime(2022, 1, 3));
- tc.verifyError(fcn,
"arrow:tabular:recordbatch:UnsupportedColumnIndexType");
+ tc.verifyError(fcn, "arrow:badsubscript:NonNumeric");
+ end
+
+ function ErrorIfIndexIsNonScalar(tc)
+ TOriginal = table(1, 2, 3);
+ arrowRecordBatch = arrow.recordbatch(TOriginal);
+ fcn = @() arrowRecordBatch.column([1 2]);
+ tc.verifyError(fcn, "MATLAB:expectedScalar");
+ end
+
+ function ErrorIfNonPositiveIndex(tc)
Review Comment:
To be consistent with the naming of `ErrorIfIndexIsNonScalar`, perhaps we
should rename this to `ErrorIfIndexIsNonPositive`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
