tustvold opened a new pull request, #4701:
URL: https://github.com/apache/arrow-rs/pull/4701
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #4596
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Adds datum based comparison kernels, deprecating the old kernels and
drastically reducing the amount of generated code.
Benchmarks show no major performance regressions, and if anything
non-trivial performance improvements.
Additionally a release build on master with dyn_cmp_dict takes
```
________________________________________________________
Executed in 39.60 secs fish external
usr time 128.19 secs 583.00 micros 128.19 secs
sys time 2.71 secs 102.00 micros 2.71 secs
```
But with the changes in this PR takes
```
________________________________________________________
Executed in 15.87 secs fish external
usr time 60.84 secs 0.00 micros 60.84 secs
sys time 2.28 secs 643.00 micros 2.28 secs
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
