tustvold commented on code in PR #4701:
URL: https://github.com/apache/arrow-rs/pull/4701#discussion_r1295735427
##########
arrow-ord/src/comparison.rs:
##########
@@ -821,1325 +750,211 @@ where
/// Note that totalOrder treats positive and negative zeros are different. If
it is necessary
/// to treat them as equal, please normalize zeros before calling this kernel.
/// Please refer to `f32::total_cmp` and `f64::total_cmp`.
+#[deprecated(note = "Use arrow_ord::cmp::neq")]
pub fn neq_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray,
ArrowError>
where
T: num::ToPrimitive + std::fmt::Debug,
{
- match left.data_type() {
- DataType::Dictionary(key_type, _value_type) => {
- dyn_compare_scalar!(left, right, key_type, neq_dyn_scalar)
- }
- _ => dyn_compare_scalar!(left, right, neq_scalar),
- }
+ let right = make_primitive_scalar(left.data_type(), right)?;
Review Comment:
I'll have a think about what to do here, I specifically do not want to
preserve the use of ToPrimitive as it breaks for things like Decimal256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
