kevingurney commented on code in PR #37189:
URL: https://github.com/apache/arrow/pull/37189#discussion_r1295071604
##########
matlab/test/arrow/io/feather/tRoundTrip.m:
##########
@@ -52,6 +52,70 @@ function Basic(testCase)
testCase.verifyEqual(tableWrite, tableRead);
end
- end
+ function NumericDatatypesNulls(testCase)
+ % Verify integers with null values are roundtripped correctly.
+ import matlab.unittest.fixtures.TemporaryFolderFixture
+ import arrow.internal.io.feather.*
+ import arrow.tabular.RecordBatch
+
+ fixture = testCase.applyFixture(TemporaryFolderFixture);
+ filename = fullfile(fixture.Folder, "temp.feather");
+
+ uint8Array = arrow.array(uint8([1, 2, 3, 4, 5]), Valid=[1, 3, 4]);
+ int16Array = arrow.array(uint8([1, 2, 3, 4, 5]), Valid=[3, 5]);
+ inputRecordBatch = RecordBatch.fromArrays(uint8Array, int16Array);
+
+ writer = Writer(filename);
+ writer.write(inputRecordBatch);
+
+ reader = Reader(filename);
+ outputRecordBatch = reader.read();
+
+ testCase.verifyEqual(outputRecordBatch.NumColumns,
inputRecordBatch.NumColumns);
+ testCase.verifyEqual(outputRecordBatch.ColumnNames,
inputRecordBatch.ColumnNames);
+
+ outColumn1 = outputRecordBatch.column(1);
+ testCase.verifyEqual(outColumn1.Valid, uint8Array.Valid);
+ testCase.verifyEqual(toMATLAB(outColumn1), toMATLAB(uint8Array));
+
+ outColumn2 = outputRecordBatch.column(2);
+ testCase.verifyEqual(outColumn2.Valid, int16Array.Valid);
+ testCase.verifyEqual(toMATLAB(outColumn2), toMATLAB(int16Array));
+ end
+
+ function InvalidMATLABTableVariableNames(testCase)
+ import matlab.unittest.fixtures.TemporaryFolderFixture
+ import arrow.internal.io.feather.*
+ import arrow.tabular.RecordBatch
+
+ fixture = testCase.applyFixture(TemporaryFolderFixture);
+ filename = fullfile(fixture.Folder, "temp.feather");
+
+ doubleArray = arrow.array([1, 2, 3, 4, 5]);
+ stringArray = arrow.array(["A", "B", "C", "D", "E"]);
+
+ % Create a RecordBatch whose first column name is an invalid
+ % variable name for a MATLAB table.
+ inputRecordBatch = RecordBatch.fromArrays(doubleArray,
stringArray, ...
+ ColumnNames=[":", "Valid"]);
+
+ writer = Writer(filename);
+ writer.write(inputRecordBatch);
+
+ % Verify the RecordBatch returned by read has the same
+ % ColumnNames as the original RecordBatch.
+ reader = Reader(filename);
+ outputRecordBatch = reader.read();
+ testCase.verifyEqual(outputRecordBatch.ColumnNames,
inputRecordBatch.ColumnNames);
+
+ % Verify the VariableNames property in the table returned by
+ % featherread have been modified and that
Review Comment:
have -> has
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
