sgilmore10 opened a new pull request, #37189:
URL: https://github.com/apache/arrow/pull/37189
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Now that we have new internal Feather V1 `arrow.internal.io.feather.Reader`
and `arrow.internal.io.feather.Writer` objects, we can re-implement the
`tfeathermex.m` tests in terms of calls to these new internal APIs. As part of
this change, we can also move these test cases into
`matlab/test/arrow/io/feather/tRoundTrip.m` and delete the old `tfeathermex.m`
file. Deleting the old Feather MEX tests will allow us to also delete the old
Feather MEX code.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
1. Moved test cases `NumericDatatypesNulls` and
`InvalidMATLABTableVariableNames` from `test/tfeathermex.m` to
`test/arrow/internal/io/feather/tRoundTrip.m`
2. Deleted `test/tfeathermex.m`
3. Deleted obsolete test utility
`test/util/createVariablesAndMetadataStructs.m`
4. Deleted obsolete test utility `test/util/featherMEXRoundTrip.m`
### Are these changes tested?
Yes. All tests pass.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
5. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
### Are there any user-facing changes?
No.
### Future Directions
1. Delete the MEX source code from the interface.
2. Moved `test/util/createTable.m` and `test/util/featherRoundTrip.m` into
package functions underneath `arrow.internal.test.m` (See #37188)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
