pitrou commented on code in PR #14341: URL: https://github.com/apache/arrow/pull/14341#discussion_r1295879261
########## cpp/src/parquet/encoding_test.cc: ########## @@ -874,7 +874,7 @@ std::shared_ptr<::arrow::Array> EncodingAdHocTyped<FLBAType>::GetValues(int seed } using EncodingAdHocTypedCases = - ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType, FLBAType>; + ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType>; Review Comment: Well... the thing is, the change brings pointless complication from the user's POV, isn't it? FixedSizeBinary arrays don't need to be broken down in multiple chunks because they have no limitation on data size. If it's purely to ease templating, why don't you use a private templated helper? You even already have `ArrowBinaryHelper` which would perhaps be expanded or adapted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
