pitrou commented on code in PR #14341: URL: https://github.com/apache/arrow/pull/14341#discussion_r1295883850
########## cpp/src/parquet/test_util.h: ########## @@ -783,8 +789,33 @@ inline void GenerateData<ByteArray>(int num_values, ByteArray* out, random_byte_array(num_values, 0, heap->data(), out, 2, max_byte_array_len); } +template <typename T> Review Comment: Perhaps add a comment explaining what this function does? For example: ```suggestion // Generate ByteArray or FLBA data where there is a given probability // for each value to share a common prefix with its predecessor. // This is useful to exercise prefix-based encodings such as DELTA_BYTE_ARRAY. template <typename T> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
