WillAyd commented on code in PR #276: URL: https://github.com/apache/arrow-nanoarrow/pull/276#discussion_r1296177023
########## src/nanoarrow/nanoarrow.h: ########## @@ -664,6 +664,10 @@ static inline ArrowErrorCode ArrowBufferAppendBufferView(struct ArrowBuffer* buf /// \brief Extract a boolean value from a bitmap static inline int8_t ArrowBitGet(const uint8_t* bits, int64_t i); +/// \brief Extract boolean values from a range in a bitmap +static inline void ArrowBitsGet(const uint8_t* bits, int64_t start_offset, int64_t length, Review Comment: What is perhaps a little confusing is that `start_offset` is number of bits for this function, whereas the set functions refer to it as number of bytes. I think that makes sense given the inputs/outputs, but maybe we should change the identifers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
