paleolimbot commented on code in PR #276: URL: https://github.com/apache/arrow-nanoarrow/pull/276#discussion_r1296218692
########## src/nanoarrow/nanoarrow.h: ########## @@ -664,6 +664,10 @@ static inline ArrowErrorCode ArrowBufferAppendBufferView(struct ArrowBuffer* buf /// \brief Extract a boolean value from a bitmap static inline int8_t ArrowBitGet(const uint8_t* bits, int64_t i); +/// \brief Extract boolean values from a range in a bitmap +static inline void ArrowBitsGet(const uint8_t* bits, int64_t start_offset, int64_t length, Review Comment: I'm not sure I understand...I think that `offset` and `length` are always "number of items" (bits for a `uint8_t* bits`; bytes for `uint8_t*`, etc) but perhaps there are functions for which this isn't the case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
