Fokko commented on code in PR #36846: URL: https://github.com/apache/arrow/pull/36846#discussion_r1296429597
########## cpp/src/arrow/table.h: ########## @@ -23,6 +23,7 @@ #include <vector> #include "arrow/chunked_array.h" // IWYU pragma: keep +#include "arrow/compute/cast.h" Review Comment: It does not seem to find the class when building the tests: ``` /usr/bin/ld: debug/libarrow.so.1300.0.0: undefined reference to `arrow::PromoteTableToSchema(std::shared_ptr<arrow::Table> const&, std::shared_ptr<arrow::Schema> const&, arrow::compute::CastOptions const&, arrow::MemoryPool*)' collect2: error: ld returned 1 exit status [319/835] Building CXX object src/arrow/compute/kernels/CMakeFiles/arrow-compute-scalar-if-else-test.dir/scalar_if_else_test.cc.o ninja: build stopped: subcommand failed. ``` Any pointers? Also, I think it would be nice to set the `CastOptions` to `::Safe()` by default, but I'm not able to get this working with the forward reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
