Fokko commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1302611446
##########
python/pyarrow/table.pxi:
##########
@@ -5066,6 +5073,16 @@ def concat_tables(tables, c_bool promote=False,
MemoryPool memory_pool=None):
for table in tables:
c_tables.push_back(table.sp_table)
+ if field_merge_options is not None:
+ if isinstance(field_merge_options, str):
+ if field_merge_options == "permissive":
+ options.field_merge_options = CField.CMergeOptions.Permissive()
+ elif field_merge_options == "default":
+ options.field_merge_options = CField.CMergeOptions.Defaults()
+ else:
+ options.field_merge_options = cython.cast(
+ FieldMergeOptions, field_merge_options).c_options
Review Comment:
Much better indeed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
