jackwener opened a new pull request, #7346: URL: https://github.com/apache/arrow-datafusion/pull/7346
## Which issue does this PR close? Closes #. ## Rationale for this change original code will remove distinct when they are children of union. But we should't remove them, because 1. distinct can decrease cardinaty/rowcount of union input 2. sometime distinct can pushdown, such as distinct can pushdown through join. 3. even if we want to remove distinct, we should create rule instead of eliminate distinct in plan builder ## What changes are included in this PR? union_distinct shouldn't remove child distinct ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
