alamb commented on code in PR #7346:
URL: https://github.com/apache/arrow-datafusion/pull/7346#discussion_r1300571757
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -593,15 +593,8 @@ impl LogicalPlanBuilder {
/// Apply a union, removing duplicate rows
pub fn union_distinct(self, plan: LogicalPlan) -> Result<Self> {
- // unwrap top-level Distincts, to avoid duplication
Review Comment:
The key point of this PR is that reshuffling around of `DISTINCT` should be
done as an optimization pass, rather than as part of the builder, if I
understand it. This makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
