lidavidm commented on code in PR #37271:
URL: https://github.com/apache/arrow/pull/37271#discussion_r1301665771
##########
cpp/src/arrow/compute/function_internal.cc:
##########
@@ -83,7 +83,8 @@ Result<std::unique_ptr<FunctionOptions>>
GenericOptionsType::Deserialize(
Result<std::unique_ptr<FunctionOptions>> DeserializeFunctionOptions(
const Buffer& buffer) {
- io::BufferReader stream(buffer);
+ // FIXME: Would ToString to heavy?
Review Comment:
What I mean is that you can keep `const Buffer&` and just explicitly wrap it
in a non-owning `shared_ptr<Buffer>` to pass to `BufferReader`, which keeps the
old behavior (zero-copy without owning)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
