lidavidm commented on code in PR #37271:
URL: https://github.com/apache/arrow/pull/37271#discussion_r1301996589
##########
cpp/src/arrow/io/memory.h:
##########
@@ -146,12 +146,9 @@ class ARROW_EXPORT BufferReader
: public internal::RandomAccessFileConcurrencyWrapper<BufferReader> {
public:
explicit BufferReader(std::shared_ptr<Buffer> buffer);
- explicit BufferReader(const Buffer& buffer);
- BufferReader(const uint8_t* data, int64_t size);
- /// \brief Instantiate from std::string or std::string_view. Does not
- /// own data
- explicit BufferReader(std::string_view data);
Review Comment:
We could even introduce static factories that have the same behavior as
these constructors, but whose names explicitly indicate that they may be unsafe
##########
cpp/src/arrow/io/memory.h:
##########
@@ -146,12 +146,9 @@ class ARROW_EXPORT BufferReader
: public internal::RandomAccessFileConcurrencyWrapper<BufferReader> {
public:
explicit BufferReader(std::shared_ptr<Buffer> buffer);
- explicit BufferReader(const Buffer& buffer);
- BufferReader(const uint8_t* data, int64_t size);
- /// \brief Instantiate from std::string or std::string_view. Does not
- /// own data
- explicit BufferReader(std::string_view data);
Review Comment:
Maybe we should deprecate instead of remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
