lidavidm commented on code in PR #989:
URL: https://github.com/apache/arrow-adbc/pull/989#discussion_r1302335936
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -926,6 +927,44 @@ def fetch_df(self) -> "pandas.DataFrame":
)
return self._results.fetch_df()
+ def fetch_record_batch(self, rows_per_batch: int) ->
Optional["_BatchIterator"]:
Review Comment:
Ah, ok, I see...so to mimic DuckDB, this should just return
RecordBatchReader, and we should remove the `read_next_batch` method below,
since that's a method of the RecordBatchReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
