lidavidm commented on code in PR #989:
URL: https://github.com/apache/arrow-adbc/pull/989#discussion_r1302336577
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -973,7 +1012,7 @@ def fetchone(self) -> Optional[tuple]:
self.rownumber += 1
return row
- def fetchmany(self, size: int):
+ def fetchmany(self, size: int) -> List[Optional[tuple]]:
Review Comment:
That said, I believe this should be `List[tuple]`
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -982,7 +1021,7 @@ def fetchmany(self, size: int):
rows.append(row)
return rows
- def fetchall(self):
+ def fetchall(self) -> List[Optional[tuple]]:
Review Comment:
This should be `List[tuple]`? We stop if we get None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
