korowa opened a new pull request, #7385:
URL: https://github.com/apache/arrow-datafusion/pull/7385
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #6743.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently `DistinctArrayAggAccumulator` stores its state as a set of scalar
values and returns it as a single scalar list. The problem is that while
merging state, accumulator, instead of adding list elements, simply adds whole
list to state as a single values, which causes errors while executing
`evaluate` on accumulator with merged state.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
`merge_state` now unpacks scalar list input and updates state with its
elements.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
- tests for merging `DistinctArrayAggAccumulator`s have been added,
- check for successful execution of `array_agg(distinct col)` has been added
to sqllogictests
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
`array_agg(distinct)` should not fail in case query execution requires
merging accumulator states (e. g. aggregation over multiple partitions)
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
