korowa commented on code in PR #7385: URL: https://github.com/apache/arrow-datafusion/pull/7385#discussion_r1303316249
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -1280,6 +1280,10 @@ NULL NULL 781 7.81 125 -117 100 # ---- # [4, 2, 3, 5, 1] +# additional count(1) forces array_agg_distinct instead of array_agg over aggregated by c2 data +statement ok +SELECT array_agg(distinct c2), count(1) FROM aggregate_test_100 Review Comment: Unfortunately, we don't have array_sort / list_sort function yet, and output of array_agg(distinct) is non-deterministic, so absence of failures is the best option of SQL-level check (as I can see it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
