tustvold commented on code in PR #7282:
URL: https://github.com/apache/arrow-datafusion/pull/7282#discussion_r1305399214
##########
datafusion/core/tests/memory_limit.rs:
##########
@@ -581,7 +581,9 @@ fn make_dict_batches() -> Vec<RecordBatch> {
// ...
// 0000000002
- let values: Vec<_> = (i..i + batch_size).map(|x|
format!("{x:010}")).collect();
+ let values: Vec<_> = (i..i + batch_size)
+ .map(|x| format!("{:010}", x / 16))
Review Comment:
This change was necessary to make it so the dictionaries contain some
repeated values, which avoids the RowConverter overheads coming to dominate the
memory usage to the point where testing the spill reservation becomes a moot
point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
