alamb commented on PR #7401: URL: https://github.com/apache/arrow-datafusion/pull/7401#issuecomment-1693616267
@JayjeetAtGithub -- I think after some thought we should put this code into DataFusion (it will need to be changed). The reason I think this belongs in DataFusion is that the arrow row converter already has a way to control if interning is used for dictionaries. I seems somewhat confusing to then also have something that automatically picks an interning strategy based on cardinality -- I think until we see others wanting to use this, let's leave this in DataFusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
