alamb commented on code in PR #7401:
URL: https://github.com/apache/arrow-datafusion/pull/7401#discussion_r1305890275
##########
datafusion/core/src/physical_plan/sorts/stream.rs:
##########
@@ -80,7 +80,7 @@ impl FusedStreams {
#[derive(Debug)]
pub struct RowCursorStream {
/// Converter to convert output of physical expressions
- converter: RowConverter,
Review Comment:
This is great 😍
Let's just move the `CardinalityAwareRowConverter` to this repo and I think
we'll be in good shape.
##########
datafusion/core/src/physical_plan/sorts/stream.rs:
##########
@@ -80,7 +80,7 @@ impl FusedStreams {
#[derive(Debug)]
pub struct RowCursorStream {
/// Converter to convert output of physical expressions
- converter: RowConverter,
Review Comment:
This is great 😍
Let's just move the `CardinalityAwareRowConverter` to this repo and I think
we'll be in good shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
